We are currently indexing your data, so search results may be incomplete until we finish.
Support reusing known sha during object creation.
This results in > 10% performance improvement during operations like rev-list.
Changes to 3 files · Browse files at ee89c0b39405 Showing diff from parent d0c3d74178d2 Diff from another changeset...
|
@@ -7,6 +7,9 @@ * Add Repo.set_description(). (Víðir Valberg Guðmundsson)
* Add a basic `dulwich.porcelain` module. (Jelmer Vernooij)
+
+ * Various performance improvements for object access.
+ (Jelmer Vernooij)
CHANGES
|
||
|
@@ -113,7 +113,7 @@ def __getitem__(self, sha):
"""Obtain an object by SHA1."""
type_num, uncomp = self.get_raw(sha)
- return ShaFile.from_raw_string(type_num, uncomp)
+ return ShaFile.from_raw_string(type_num, uncomp, sha=sha)
def __iter__(self):
"""Iterate over the SHAs that are present in this store."""
|
||
|
@@ -291,17 +291,20 @@ self._deserialize(self._chunked_text)
self._needs_parsing = False
- def set_raw_string(self, text):
+ def set_raw_string(self, text, sha=None):
"""Set the contents of this object from a serialized string."""
if type(text) != str:
raise TypeError(text)
- self.set_raw_chunks([text])
-
- def set_raw_chunks(self, chunks):
+ self.set_raw_chunks([text], sha)
+
+ def set_raw_chunks(self, chunks, sha=None):
"""Set the contents of this object from a list of chunks."""
self._chunked_text = chunks
self._deserialize(chunks)
- self._sha = None
+ if sha is None:
+ self._sha = None
+ else:
+ self._sha = FixedSha(sha)
self._needs_parsing = False
self._needs_serialization = False
@@ -403,25 +406,27 @@ raise ObjectFormatException("invalid object header")
@staticmethod
- def from_raw_string(type_num, string):
+ def from_raw_string(type_num, string, sha=None):
"""Creates an object of the indicated type from the raw string given.
:param type_num: The numeric type of the object.
:param string: The raw uncompressed contents.
+ :param sha: Optional known sha for the object
"""
obj = object_class(type_num)()
- obj.set_raw_string(string)
+ obj.set_raw_string(string, sha)
return obj
@staticmethod
- def from_raw_chunks(type_num, chunks):
+ def from_raw_chunks(type_num, chunks, sha=None):
"""Creates an object of the indicated type from the raw chunks given.
:param type_num: The numeric type of the object.
:param chunks: An iterable of the raw uncompressed contents.
+ :param sha: Optional known sha for the object
"""
obj = object_class(type_num)()
- obj.set_raw_chunks(chunks)
+ obj.set_raw_chunks(chunks, sha)
return obj
@classmethod
|
||
Add a tag
Loading...