Kiln » gitkiln Read More
Clone URL:  
Pushed to one repository · View In Graph Contained in master

errors made by Errorf shouldn't have newlines

Changeset cf5e6ffac8b7…

Parent 095fd82adc29…

by Profile picture of User 12Benjamin Pollack <benjamin@fogcreek.com>

Changes to 3 files · Browse files at cf5e6ffac8b7 Showing diff from parent 095fd82adc29 Diff from another changeset...

Change 1 of 1 Show Entire File kiln/​api.go Stacked
 
78
79
80
81
 
82
83
84
 
78
79
80
 
81
82
83
84
@@ -78,7 +78,7 @@
  var errors ApiErrors   if err = json.Unmarshal(resp, &errors); err == nil {   if kilnErr, _ := errors["errors"]; len(kilnErr) > 0 { - err = fmt.Errorf("failed: %v\n", kilnErr[0].Description) + err = fmt.Errorf("failed: %v", kilnErr[0].Description)   return   }   }
Change 1 of 1 Show Entire File kiln/​kiln.go Stacked
 
82
83
84
85
 
86
87
88
89
90
 
91
92
93
 
82
83
84
 
85
86
87
88
89
 
90
91
92
93
@@ -82,12 +82,12 @@
  login, password := requestUserCredentials()   resp, err := k.apiGet("Auth/Login", apiParams{"sUser": login, "sPassword": password})   if err != nil { - return fmt.Errorf("unable to contact Kiln: %v\n", err) + return fmt.Errorf("unable to contact Kiln: %v", err)   }   var errors ApiErrors   if err = json.Unmarshal(resp, &errors); err == nil {   if err, _ := errors["errors"]; len(err) > 0 { - return fmt.Errorf("failed: %v\n", err[0].Description) + return fmt.Errorf("failed: %v", err[0].Description)   }   }   if err = json.Unmarshal(resp, &k.credentials.Token); err != nil {
Change 1 of 1 Show Entire File main.go Stacked
 
82
83
84
85
 
86
87
88
 
82
83
84
 
85
86
87
88
@@ -82,7 +82,7 @@
  } else {   idx := strings.Index(base.Path, kilnUrlSuffix)   if idx < 0 { - err = fmt.Errorf("not sure where Kiln is based on %v\n", base) + err = fmt.Errorf("not sure where Kiln is based on %v", base)   return   }   base.Path = base.Path[0 : idx+len(kilnUrlSuffix)]