Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 1.9, 1.9.1, and 1.9.2

hgemail: clean up form validation codes

Changeset 0acebf718f67…

Parent ff7e43743a77…

by Yuya Nishihara

Changes to one file · Browse files at 0acebf718f67 Showing diff from parent ff7e43743a77 Diff from another changeset...

Change 1 of 4 Show Entire File tortoisehg/​hgqt/​hgemail.py Stacked
 
37
38
39
 
40
41
42
43
44
 
45
46
47
 
96
97
98
99
100
 
101
102
103
 
202
203
204
205
206
 
 
207
208
209
 
 
 
210
211
212
 
213
214
215
216
217
 
218
219
220
 
247
248
249
250
251
252
253
254
 
 
255
256
257
 
37
38
39
40
41
42
43
 
 
44
45
46
47
 
96
97
98
 
 
99
100
101
102
 
201
202
203
 
 
204
205
206
207
208
209
210
211
212
 
 
213
214
 
 
 
 
215
216
217
218
 
245
246
247
 
 
 
 
 
248
249
250
251
252
@@ -37,11 +37,11 @@
    self._initchangesets(revs)   self._initpreviewtab() + self._initenvelopebox()   self._initintrobox()   self._readhistory()   self._filldefaults() - self._connectvalidateform() - self._validateform() + self._updateforms()   self._readsettings()     def keyPressEvent(self, event): @@ -96,8 +96,7 @@
    self._changesets = _ChangesetsModel(self._repo, purerevs(revs),   parent=self) - self._changesets.dataChanged.connect(self._validateform) - self._changesets.dataChanged.connect(self._updateintrobox) + self._changesets.dataChanged.connect(self._updateforms)   self._qui.changesets_view.setModel(self._changesets)     @property @@ -202,19 +201,18 @@
  return True     @pyqtSlot() - def _validateform(self): - """Check form values to update send/preview availability""" + def _updateforms(self): + """Update availability of form widgets"""   valid = self._isvalid()   self._qui.send_button.setEnabled(valid)   self._qui.main_tabs.setTabEnabled(self._previewtabindex(), valid) + self._qui.writeintro_check.setEnabled(not self._introrequired()) + if self._introrequired(): + self._qui.writeintro_check.setChecked(True)   - def _connectvalidateform(self): - # TODO: connect programmatically + def _initenvelopebox(self):   for e in ('to_edit', 'from_edit'): - getattr(self._qui, e).editTextChanged.connect(self._validateform) - - self._qui.subject_edit.textChanged.connect(self._validateform) - self._qui.writeintro_check.toggled.connect(self._validateform) + getattr(self._qui, e).editTextChanged.connect(self._updateforms)     def accept(self):   # TODO: want to pass patchbombopts directly @@ -247,11 +245,8 @@
    def _initintrobox(self):   self._qui.intro_box.hide() # hidden by default - self._qui.writeintro_check.setChecked(self._introrequired()) - self._updateintrobox() - - def _updateintrobox(self): # TODO: merge into _validateform - self._qui.writeintro_check.setEnabled(not self._introrequired()) + self._qui.subject_edit.textChanged.connect(self._updateforms) + self._qui.writeintro_check.toggled.connect(self._updateforms)     def _introrequired(self):   """Is intro message required?"""