Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 0.8, 0.8.1, and 0.8.2

shellext: fix a subtle bug with added files

This bug manifested itself reliably on 64 bit Windows 7 RC build 7100
with 64 bit explorer. The effect was that files most of the time
didn't have any overlay icon. Having a single added file seemed
to cure it.

The reason why this bug was discovered is that Windows 7 seems
to call the overlay handlers in more randomized order, compared to
Windows XP, where the handlers are called in a very deterministic
order (mostly determined by the order in which they are registered
in the registry, as it seems).

(Besides that Windows 7 calls the handlers from multiple threads,
see 0a4df15f49de.)

Changeset 0bbb1013ba72

Parent 6f05311af913

by Adrian Buehlmann

Changes to one file · Browse files at 0bbb1013ba72 Showing diff from parent 6f05311af913 Diff from another changeset...

 
199
200
201
202
 
203
204
205
 
199
200
201
 
202
203
204
205
@@ -199,7 +199,7 @@
  }     if (filterStatus == 'A' && pds->num_added() == 0) { - last = cur; + // don't store QueryState   return 0;   }