Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 0.8.2, 0.8.3, and 0.9

stable shellext: return empty verbs in CShellExt::GetCommandString (issue 442)

"Rename File" from TortoiseHg submenu triggered a simple file rename
instead of hgtk rename.

It seems the "rename" verb conflicted with the "rename" commmand of explorer.

Return empty verb strings in GetCommandString for now, as it seems they are
not needed anyway.

If the verbs should be needed in the future, the command names in menuDescList
should probably be changed or get a distinctive prefix.

Changeset 0ca4ab648cc5…

Parent 3c0887c39d61…

by Adrian Buehlmann

Changes to one file · Browse files at 0ca4ab648cc5 Showing diff from parent 3c0887c39d61 Diff from another changeset...

Change 1 of 1 Show Entire File win32/​shellext/​ContextMenu.cpp Stacked
 
517
518
519
 
520
 
 
 
 
521
522
523
 
517
518
519
520
521
522
523
524
525
526
527
528
@@ -517,7 +517,12 @@
  }   else if (uFlags == GCS_VERBW || uFlags == GCS_VERBA)   { +#if 0   psz = iter->second.name.c_str(); +#else + // bugfix: don't provide verbs ("rename" conflicted with rename of explorer) + psz = ""; +#endif   res = S_OK;   }   else if (uFlags == GCS_VALIDATEW || uFlags == GCS_VALIDATEA)