Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 1.9, 1.9.1, and 1.9.2

sync: do not store Python reference to parent, use signaling

Changeset 36ee12802f4f…

Parent dfe1654d52ce…

by Steve Borho

Changes to one file · Browse files at 36ee12802f4f Showing diff from parent dfe1654d52ce Diff from another changeset...

Change 1 of 4 Show Entire File tortoisehg/​hgqt/​sync.py Stacked
 
161
162
163
 
164
165
166
 
589
590
591
 
592
 
593
594
595
 
853
854
855
 
 
856
857
858
859
860
861
862
863
864
 
874
875
876
877
878
 
879
880
881
 
161
162
163
164
165
166
167
 
590
591
592
593
594
595
596
597
598
 
856
857
858
859
860
861
862
863
864
865
 
866
867
868
 
878
879
880
 
 
881
882
883
884
@@ -161,6 +161,7 @@
    self.hgrctv = PathsTree(self, True)   self.hgrctv.clicked.connect(self.pathSelected) + self.hgrctv.removeAlias.connect(self.removeAlias)   pathsframe = QFrame()   pathsframe.setFrameStyle(QFrame.StyledPanel|QFrame.Raised)   pathsbox = QVBoxLayout() @@ -589,7 +590,9 @@
  from tortoisehg.hgqt import run as _run   _run.email(ui.ui(), root=self.root)   + @pyqtSlot(QString)   def removeAlias(self, alias): + alias = hglib.fromunicode(alias)   fn = os.path.join(self.root, '.hg', 'hgrc')   fn, cfg = loadIniFile([fn], self)   if not hasattr(cfg, 'write'): @@ -853,12 +856,13 @@
     class PathsTree(QTreeView): + removeAlias = pyqtSignal(QString) +   def __init__(self, parent, editable):   QTreeView.__init__(self, parent)   self.setSelectionMode(QTreeView.SingleSelection)   self.setContextMenuPolicy(Qt.CustomContextMenu)   self.customContextMenuRequested.connect(self.menuRequest) - self.parent = parent   self.editable = editable     def keyPressEvent(self, event): @@ -874,8 +878,7 @@
  _('Delete %s from your repo configuration file?') % alias,   parent=self)   if r: - alias = hglib.fromunicode(alias) - self.parent.removeAlias(alias) + self.removeAlias.emit(alias)     def dragObject(self):   urls = []