Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in tip

fogcreek shellext: use Boolean data type for function with Boolean return value

Changeset 375f38b7c99b…

Parent d686593476cd…

by David Golub

Changes to 2 files · Browse files at 375f38b7c99b Showing diff from parent d686593476cd Diff from another changeset...

Change 1 of 1 Show Entire File win32/​shellext/​RegistryConfig.cpp Stacked
 
18
19
20
21
 
22
23
24
25
 
26
27
28
29
30
 
31
32
 
33
34
35
 
18
19
20
 
21
22
23
24
 
25
26
27
28
29
 
30
31
 
32
33
34
35
@@ -18,18 +18,18 @@
 #include "RegistryConfig.h"  #include "TortoiseUtils.h"   -int GetRegistryConfig(const CString& strName, CString& strRes) +bool GetRegistryConfig(const CString& strName, CString& strRes)  {   CRegKey key;   LONG lRes = key.Open(HKEY_CURRENT_USER, "Software\\TortoiseHg", KEY_READ); - if (lRes != ERROR_SUCCESS || key.m_hKey == 0) return 0; + if (lRes != ERROR_SUCCESS || key.m_hKey == NULL) return false;     DWORD cbData = MAX_PATH;   TCHAR szData[MAX_PATH];   lRes = key.QueryStringValue(strName, szData, &cbData); - if (lRes != ERROR_SUCCESS) return 0; + if (lRes != ERROR_SUCCESS) return false;   strRes = szData; - return 1; + return true;  }    void GetCMenuTranslation(const CString& strLang, LPCTSTR lpszName,
Change 1 of 1 Show Changes Only win32/​shellext/​RegistryConfig.h Stacked
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
 
19
20
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
 
18
19
20
 // Copyright (C) 2011 Fog Creek Software  //  // This program is free software: you can redistribute it and/or modify  // it under the terms of the GNU General Public License as published by  // the Free Software Foundation, either version 2 of the License, or  // (at your option) any later version.  //  // This program is distributed in the hope that it will be useful,  // but WITHOUT ANY WARRANTY; without even the implied warranty of  // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the  // GNU General Public License for more details.  //  // You should have received a copy of the GNU General Public License  // along with this program. If not, see <http://www.gnu.org/licenses/>.    #pragma once   -int GetRegistryConfig(const CString& strName, CString& strRes); +bool GetRegistryConfig(const CString& strName, CString& strRes);  void GetCMenuTranslation(const CString& strLang, LPCTSTR lpszName,   CStringW& strMenuText, CStringW& strHelpText);