Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 0.9.2, 0.9.3, and 1.0

stable shellext: use S_OK instead of NOERROR

Not knowingly fixing a bug, but S_OK seems to be the preferred style

Changeset 44714cae81dc…

Parent f63cc5b686ac…

by Adrian Buehlmann

Changes to 3 files · Browse files at 44714cae81dc Showing diff from parent f63cc5b686ac Diff from another changeset...

Change 1 of 5 Show Entire File win32/​shellext/​CShellExtCMenu.cpp Stacked
 
359
360
361
362
 
363
364
365
 
535
536
537
538
 
539
540
541
 
726
727
728
729
 
730
731
732
 
733
734
735
 
874
875
876
877
 
878
879
880
 
936
937
938
939
 
940
941
942
 
359
360
361
 
362
363
364
365
 
535
536
537
 
538
539
540
541
 
726
727
728
 
729
730
731
 
732
733
734
735
 
874
875
876
 
877
878
879
880
 
936
937
938
 
939
940
941
942
@@ -359,7 +359,7 @@
  bAppendItems = FALSE;     if (!bAppendItems) - return NOERROR; + return S_OK;     const std::size_t sz = sizeof(menuDescList) / sizeof(MenuDescription);   bool promoted[sz]; @@ -535,7 +535,7 @@
  if (iter != MenuIdMap.end())   {   DoHgtk(iter->second.name); - hr = NOERROR; + hr = S_OK;   }   else   { @@ -726,10 +726,10 @@
  break;     default: - return NOERROR; + return S_OK;   }   - return NOERROR; + return S_OK;  }     @@ -874,7 +874,7 @@
  myFolder = name;   }   - return NOERROR; + return S_OK;  }     @@ -936,7 +936,7 @@
  if (*ppv)   {   AddRef(); - return NOERROR; + return S_OK;   }     return E_NOINTERFACE;
Change 1 of 1 Show Entire File win32/​shellext/​CShellExtOverlay.cpp Stacked
 
103
104
105
106
 
107
108
109
 
103
104
105
 
106
107
108
109
@@ -103,7 +103,7 @@
  if (*ppv)   {   AddRef(); - return NOERROR; + return S_OK;   }     return E_NOINTERFACE;
Change 1 of 2 Show Entire File win32/​shellext/​ThgClassFactory.h Stacked
 
37
38
39
40
 
41
42
43
 
87
88
89
90
 
91
92
93
 
37
38
39
 
40
41
42
43
 
87
88
89
 
90
91
92
93
@@ -37,7 +37,7 @@
  {   *ppv = (LPCLASSFACTORY) this;   AddRef(); - return NOERROR; + return S_OK;   }     return E_NOINTERFACE; @@ -87,7 +87,7 @@
    STDMETHODIMP LockServer(BOOL fLock)   { - return NOERROR; + return S_OK;   }    };