Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 2.0.1, 2.0.2, and 2.0.3

stable workbench: dispose of the RepoWidget when removing the tab

QTabWidget.removeTab() only removes the page - it doesn't dispose of it. It
doesn't seem like there would be any remaining references to the removed
RepoWidget except internally, but apparently the right thing to do is to call
"deleteLater()" manually.

Changeset 5aba622d4a65…

Parent 2d23a43b3135…

by Daniel Atallah

Changes to one file · Browse files at 5aba622d4a65 Showing diff from parent 2d23a43b3135 Diff from another changeset...

Change 1 of 2 Show Entire File tortoisehg/​hgqt/​workbench.py Stacked
 
448
449
450
 
451
452
453
 
455
456
457
 
458
459
460
 
448
449
450
451
452
453
454
 
456
457
458
459
460
461
462
@@ -448,6 +448,7 @@
  index = self.repoTabsWidget.currentIndex()   if widget.closeRepoWidget():   self.repoTabsWidget.removeTab(index) + widget.deleteLater()   self.updateMenu()     def repoTabCloseRequested(self, index): @@ -455,6 +456,7 @@
  w = tw.widget(index)   if w and w.closeRepoWidget():   tw.removeTab(index) + w.deleteLater()   self.updateMenu()     def repoTabChanged(self, index=0):