Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 2.0.3, 2.0.4, and 2.0.5

stable postreview: fixed issue on linux where the version variable always yielded an AttributeError

Changeset 68a7b0de052a…

Parent fcadbfb1d6bd…

by Michael De Wildt

Changes to one file · Browse files at 68a7b0de052a Showing diff from parent fcadbfb1d6bd Diff from another changeset...

Change 1 of 1 Show Entire File tortoisehg/​hgqt/​postreview.py Stacked
 
36
37
38
39
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
 
36
37
38
 
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
59
60
61
@@ -36,30 +36,26 @@
  msg = _("Invalid Settings - Please provide your ReviewBoard username")   else:   rb = extensions.find("reviewboard") - plugin_msg = _("Invalid reviewboard plugin. Please download the " + try: + pwd = self.dialog.password + #if we don't have a password send something here to skip + #the cli getpass in the extension. We will set the password + #later + if not pwd: + pwd = "None" + + self.reviewboard = rb.make_rbclient(self.dialog.server, + self.dialog.user, + pwd) + self.loadCombos() + + except rb.ReviewBoardError, e: + msg = e.msg + except TypeError: + msg = _("Invalid reviewboard plugin. Please download the "   "mercurial reviewboard plugin version 3.5 or higher "   "from the website below.\n\n %s") % \   u'http://bitbucket.org/mdelagra/mercurial-reviewboard/' - try: - if float(rb.__version__[:3]) < 3.5: - msg = plugin_msg - else: - pwd = self.dialog.password - #if we don't have a password send something here to skip - #the cli getpass in the extension. We will set the password - #later - if not pwd: - pwd = "None" - - self.reviewboard = rb.make_rbclient(self.dialog.server, - self.dialog.user, - pwd) - self.loadCombos() - - except rb.ReviewBoardError, e: - msg = e.msg - except AttributeError: - msg = plugin_msg     self.dialog.error_message = msg