Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in tip

fogcreek shellext: use Boolean data type for function with Boolean return value

Changeset 7654159f827b…

Parent 375f38b7c99b…

by David Golub

Changes to 2 files · Browse files at 7654159f827b Showing diff from parent 375f38b7c99b Diff from another changeset...

Change 1 of 2 Show Entire File win32/​shellext/​TortoiseUtils.cpp Stacked
 
223
224
225
226
 
227
228
229
 
233
234
235
236
 
237
238
 
239
240
241
 
223
224
225
 
226
227
228
229
 
233
234
235
 
236
237
 
238
239
240
241
@@ -223,7 +223,7 @@
 }    // read string value from registry, wide version -int GetRegSZValueW(HKEY hKey, LPCWSTR lpszName, CStringW& strRes) +bool GetRegSZValueW(HKEY hKey, LPCWSTR lpszName, CStringW& strRes)  {   strRes = L"";   if (!hKey) return 0; @@ -233,9 +233,9 @@
  LONG lRes = ::RegQueryValueExW(hKey, lpszName, 0, 0, (LPBYTE)lpszData, &cbData);   strRes.ReleaseBuffer(cbData);   - if (lRes == ERROR_SUCCESS) return 1; + if (lRes == ERROR_SUCCESS) return true;   ATLTRACE(L"GetRegSZValueW('%s') failed\n", lpszName); - return 0; + return false;  }    // true if a starts with b
Change 1 of 1 Show Changes Only win32/​shellext/​TortoiseUtils.h Stacked
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
 
28
29
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
 
27
28
29
 // Copyright (C) 2011 Fog Creek Software  //  // This program is free software: you can redistribute it and/or modify  // it under the terms of the GNU General Public License as published by  // the Free Software Foundation, either version 2 of the License, or  // (at your option) any later version.  //  // This program is distributed in the hope that it will be useful,  // but WITHOUT ANY WARRANTY; without even the implied warranty of  // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the  // GNU General Public License for more details.  //  // You should have received a copy of the GNU General Public License  // along with this program. If not, see <http://www.gnu.org/licenses/>.    #pragma once    CString GetTHgProgRoot();  CString GetTemporaryFile(LPCSTR strPrefix = "THG");  CString DirName(const CString& strFileName);  CString BaseName(const CString& strFileName);  bool LaunchCommand(const CString& strCommand, const CString& strCwd);  HICON GetTortoiseIcon(const CString& strIconName);  CString GetHgRepoRoot(LPCTSTR lpszPath);  bool IsHgRepo(const CString& lpszPath);  FILE* fopenReadRenameAllowed(LPCTSTR lpszPath); -int GetRegSZValueW(HKEY hKey, LPCWSTR lpszName, CStringW& strRes); +bool GetRegSZValueW(HKEY hKey, LPCWSTR lpszName, CStringW& strRes);  bool StartsWith(const CString& strWhole, const CString& strPrefix);  void Tokenize(CString str, CAtlList<CString>& rTokens, LPCTSTR lpszDelimiters = " ");