Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 1.9.3, 2.0, and 2.0.1

stable hgemail: remove redundant close method, connect finished signal to deleteLater

This connection has helped other dialogs from crashing (mysteriously). So we'll
see if this aids the crashes some have been reporting when they click the send
button.

Changeset 8b64a0641ca3…

Parent 181c004406d5…

by Steve Borho

Changes to one file · Browse files at 8b64a0641ca3 Showing diff from parent 181c004406d5 Diff from another changeset...

Change 1 of 2 Show Entire File tortoisehg/​hgqt/​hgemail.py Stacked
 
240
241
242
243
244
245
246
247
248
 
264
265
266
 
267
268
269
 
240
241
242
 
 
 
243
244
245
 
261
262
263
264
265
266
267
@@ -240,9 +240,6 @@
  for e in ('to_edit', 'from_edit'):   getattr(self._qui, e).editTextChanged.connect(self._updateforms)   - def close(self): - super(EmailDialog, self).accept() -   def accept(self):   # TODO: want to pass patchbombopts directly   def cmdargs(opts): @@ -264,6 +261,7 @@
  cmd = cmdui.Dialog(['email'] + cmdargs(opts), parent=self)   cmd.setWindowTitle(_('Sending Email'))   cmd.setShowOutput(False) + cmd.finished.connect(cmd.deleteLater)   if cmd.exec_():   self._writehistory()   super(EmailDialog, self).accept()