Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 0.8, 0.8.1, and 0.8.2

cmenu: re-set cbData before second RegQueryValueExA

Without resetting this value, the second read could only succeed
if it was smaller in length than the first. Since the first read
was the menu text and the second was the help text, this was mostly
broken.

Changeset 8cf122017c8b…

Parent 4634a1bf3be5…

by Steve Borho

Changes to one file · Browse files at 8cf122017c8b Showing diff from parent 4634a1bf3be5 Diff from another changeset...

Change 1 of 1 Show Entire File win32/​shellext/​ContextMenu.cpp Stacked
 
149
150
151
 
152
153
154
 
149
150
151
152
153
154
155
@@ -149,6 +149,7 @@
  if (rv == ERROR_SUCCESS)   menuText = reinterpret_cast<const char*>(&Data);   + cbData = MAX_PATH * sizeof(BYTE);   rv = RegQueryValueExA(hkey, "helpText", 0, 0, Data, &cbData);   if (rv == ERROR_SUCCESS)   helpText = reinterpret_cast<const char*>(&Data);