Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 0.9, 0.9.1, and 0.9.1.1

gdialog: refactoring: rename enable_cmd to cmd_set_sensitive

This fits better together with the related cmd_set_active.

The term "enable" is too imprecise ("does it mean 'make sensitive'
or 'make active'?").

Let's stick to gtk's terms ('active' and 'sensitive') and not
add a confusing third one.

(this fixes my bad name choice I made in 8a3740495e23)

Changeset 8eed10404f45…

Parent 2cec4e0adfbe…

by Adrian Buehlmann

Changes to 4 files · Browse files at 8eed10404f45 Showing diff from parent 2cec4e0adfbe Diff from another changeset...

Change 1 of 1 Show Entire File tortoisehg/​hgtk/​commit.py Stacked
 
630
631
632
633
 
634
635
636
 
630
631
632
 
633
634
635
636
@@ -630,7 +630,7 @@
  def check_undo(self):   can_undo = os.path.exists(self.repo.sjoin("undo")) and \   self.last_commit_id is not None - self.enable_cmd('undo', can_undo) + self.cmd_set_sensitive('undo', can_undo)     def check_merge(self):   if self.is_merge():
Change 1 of 1 Show Entire File tortoisehg/​hgtk/​gdialog.py Stacked
 
336
337
338
339
 
340
341
342
343
344
345
 
346
347
348
 
336
337
338
 
339
340
341
342
343
344
 
345
346
347
348
@@ -336,13 +336,13 @@
  def get_menuitem(self, name):   return self.menuitems[name]   - def enable_cmd(self, name, enable): + def cmd_set_sensitive(self, name, sensitive):   ws = []   ws.append(self.toolbuttons.get(name))   ws.append(self.menuitems.get(name))   for w in ws:   if w: - w.set_sensitive(enable) + w.set_sensitive(sensitive)     def cmd_set_active(self, name, active):   ws = []
Change 1 of 10 Show Entire File tortoisehg/​hgtk/​history.py Stacked
 
203
204
205
206
 
207
208
209
 
217
218
219
220
 
221
222
223
 
255
256
257
258
259
 
 
260
261
262
 
278
279
280
281
282
 
 
283
284
285
 
332
333
334
335
336
 
 
337
338
339
 
463
464
465
466
467
 
 
468
469
470
 
578
579
580
581
582
 
 
583
584
585
 
1072
1073
1074
1075
1076
 
 
1077
1078
1079
 
1135
1136
1137
1138
1139
 
 
1140
1141
1142
 
1760
1761
1762
1763
 
1764
1765
1766
 
203
204
205
 
206
207
208
209
 
217
218
219
 
220
221
222
223
 
255
256
257
 
 
258
259
260
261
262
 
278
279
280
 
 
281
282
283
284
285
 
332
333
334
 
 
335
336
337
338
339
 
463
464
465
 
 
466
467
468
469
470
 
578
579
580
 
 
581
582
583
584
585
 
1072
1073
1074
 
 
1075
1076
1077
1078
1079
 
1135
1136
1137
 
 
1138
1139
1140
1141
1142
 
1760
1761
1762
 
1763
1764
1765
1766
@@ -203,7 +203,7 @@
    def synch_clicked(self, toolbutton, data):   def sync_closed(dialog): - self.enable_cmd('synchronize', True) + self.cmd_set_sensitive('synchronize', True)     def synch_callback(parents):   self.repo.invalidate() @@ -217,7 +217,7 @@
  dlg.set_notify_func(synch_callback, parents)   dlg.connect('destroy', sync_closed)   dlg.show_all() - self.enable_cmd('synchronize', False) + self.cmd_set_sensitive('synchronize', False)     def toggle_view_column(self, button, property):   active = button.get_active() @@ -255,8 +255,8 @@
    def load_all_clicked(self, button, data=None):   self.graphview.load_all_revisions() - self.enable_cmd('load-more', False) - self.enable_cmd('load-all', False) + self.cmd_set_sensitive('load-more', False) + self.cmd_set_sensitive('load-all', False)     def selection_changed(self, graphview):   'Graphview reports a new row selected' @@ -278,8 +278,8 @@
  if not graphview.graphdata:   self.changeview._buffer.set_text('')   self.changeview._filelist.clear() - self.enable_cmd('load-more', False) - self.enable_cmd('load-all', False) + self.cmd_set_sensitive('load-more', False) + self.cmd_set_sensitive('load-all', False)     def details_clicked(self, toolbutton, data=None):   self.show_details_dialog() @@ -332,8 +332,8 @@
  if self.graphcol != show:   self.graphcol = show   reload = True - self.enable_cmd('compact-graph', self.graphcol) - self.enable_cmd('color-by-branch', self.graphcol) + self.cmd_set_sensitive('compact-graph', self.graphcol) + self.cmd_set_sensitive('color-by-branch', self.graphcol)   else:   self.graphview.set_property(property, show)   self.showcol[property] = show @@ -463,8 +463,8 @@
  # persisted data   pass   - self.enable_cmd('compact-graph', self.graphcol) - self.enable_cmd('color-by-branch', self.graphcol) + self.cmd_set_sensitive('compact-graph', self.graphcol) + self.cmd_set_sensitive('color-by-branch', self.graphcol)     item = self.get_menuitem('use-proxy-server')   if ui.ui().config('http_proxy', 'host'): @@ -578,8 +578,8 @@
  opts['npreviews'] = self.npreviews   opts['no_merges'] = self.no_merges   - self.enable_cmd('load-more', True) - self.enable_cmd('load-all', True) + self.cmd_set_sensitive('load-more', True) + self.cmd_set_sensitive('load-all', True)   self.ancestrybutton.set_sensitive(False)   pats = opts.get('pats', [])   self.changeview.pats = pats @@ -1072,8 +1072,8 @@
  self.reload_log()   self.toolbar.remove(self.toolbar.get_nth_item(0))   self.toolbar.remove(self.toolbar.get_nth_item(0)) - self.enable_cmd('accept', False) - self.enable_cmd('reject', False) + self.cmd_set_sensitive('accept', False) + self.cmd_set_sensitive('reject', False)   for w in self.incoming_disabled:   w.set_sensitive(True)   @@ -1135,8 +1135,8 @@
  self.toolbar.insert(reject, 0)   self.toolbar.insert(apply, 0)   - self.enable_cmd('accept', True) - self.enable_cmd('reject', True) + self.cmd_set_sensitive('accept', True) + self.cmd_set_sensitive('reject', True)     self.incoming_disabled = []   for cmd in ('refresh', 'synchronize', 'mq'): @@ -1760,7 +1760,7 @@
  self.mqtb.handler_block_by_func(self.mq_clicked)   self.cmd_set_active('mq', enable)   self.mqtb.handler_unblock_by_func(self.mq_clicked) - self.enable_cmd('mq', self.mqwidget.has_mq()) + self.cmd_set_sensitive('mq', self.mqwidget.has_mq())     def mq_clicked(self, widget, data=None):   self.enable_mqpanel(widget.get_active())
Change 1 of 1 Show Entire File tortoisehg/​hgtk/​status.py Stacked
 
460
461
462
463
 
464
465
466
 
460
461
462
 
463
464
465
466
@@ -460,7 +460,7 @@
  return   sensitive = check_count and not self.is_merge()   for cmd in ('diff', 'revert', 'add', 'remove', 'move', 'forget'): - self.enable_cmd(cmd, sensitive) + self.cmd_set_sensitive(cmd, sensitive)   if self.diff_notebook.get_current_page() == 2:   self.update_commit_preview()