Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 1.9.2, 1.9.3, and 2.0

postreview: fixed a threading issue when the dialog was closed while a command was running

Changeset 961885a6e4ad…

Parent cdbcf16b8a7b…

by Michael De Wildt

Changes to one file · Browse files at 961885a6e4ad Showing diff from parent cdbcf16b8a7b Diff from another changeset...

Change 1 of 3 Show Entire File tortoisehg/​hgqt/​postreview.py Stacked
 
85
86
87
 
88
89
90
 
132
133
134
 
 
 
 
135
136
137
 
304
305
306
307
308
309
310
 
85
86
87
88
89
90
91
 
133
134
135
136
137
138
139
140
141
142
 
309
310
311
 
312
313
314
@@ -85,6 +85,7 @@
  self.ui = ui   self.repo = repo   self.error_message = None + self.cmd = None     self.qui = Ui_PostReviewDialog()   self.qui.setupUi(self) @@ -132,6 +133,10 @@
  self.qui.post_review_button.setEnabled(True)     def closeEvent(self, event): + if self.cmd and self.cmd.core.running(): + self.cmd.commandFinished.disconnect(self.onCompletion) + self.cmd.cancel() +   # Dispose of the review data thread   self.review_thread.terminate()   self.review_thread.wait() @@ -304,7 +309,6 @@
  self.qui.changesets_view.setEnabled(True)     def close(self): - self.cmd.cancel()   super(PostReviewDialog, self).close()     def accept(self):