Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 1.0.1, 1.0.2, and 1.0.3

stable wix/shell-register.wxi: use HKLM instead of HKMU

HKMU resolves to either HKLM (HKEY_LOCAL_MACHINE) or HKCU (HKEY_CURRENT_USER), depending
on the value of the ALLUSERS property.

Since we do (and must) have ALLUSERS set to 1, this currently works, but using HKMU here is
pointless, misleading, and dangerous, since there is no
'Software\Microsoft\Windows\CurrentVersion\Shell Extensions\Approved' or
'Software\TortoiseOverlays\{Normal|Added|Modified|Unversioned}' registry key in
HKEY_CURRENT_USER anyway.

So, let's be honest and explicit here and use HKEY_LOCAL_MACHINE (HKLM). A per-user install
of the Windows shell extensions is impossible anyway.

Changeset 9c25484a5a67…

Parent 7e7c56954bcb…

by Adrian Buehlmann

Changes to one file · Browse files at 9c25484a5a67 Showing diff from parent 7e7c56954bcb Diff from another changeset...

Change 1 of 1 Show Entire File contrib/​wix/​shell-register.wxi Stacked
 
81
82
83
84
 
85
86
87
88
 
89
90
91
92
 
93
94
95
96
 
97
98
99
100
101
102
 
103
104
105
106
 
107
108
109
110
 
111
112
113
114
 
115
116
117
118
 
119
120
121
 
81
82
83
 
84
85
86
87
 
88
89
90
91
 
92
93
94
95
 
96
97
98
99
100
101
 
102
103
104
105
 
106
107
108
109
 
110
111
112
113
 
114
115
116
117
 
118
119
120
121
@@ -81,41 +81,41 @@
    <!-- register overlay components with TortoiseOverlays -->   <RegistryValue - Root='HKMU' Key='Software\TortoiseOverlays\Normal' + Root='HKLM' Key='Software\TortoiseOverlays\Normal'   Type='string' Name='TortoiseHgMsi' Value='$(var.CLSID_TortoiseHgNormal)'   />   <RegistryValue - Root='HKMU' Key='Software\TortoiseOverlays\Added' + Root='HKLM' Key='Software\TortoiseOverlays\Added'   Type='string' Name='TortoiseHgMsi' Value='$(var.CLSID_TortoiseHgAdded)'   />   <RegistryValue - Root='HKMU' Key='Software\TortoiseOverlays\Modified' + Root='HKLM' Key='Software\TortoiseOverlays\Modified'   Type='string' Name='TortoiseHgMsi' Value='$(var.CLSID_TortoiseHgModified)'   />   <RegistryValue - Root='HKMU' Key='Software\TortoiseOverlays\Unversioned' + Root='HKLM' Key='Software\TortoiseOverlays\Unversioned'   Type='string' Name='TortoiseHgMsi' Value='$(var.CLSID_TortoiseHgUnversioned)'   />     <!-- Mark all as approved -->   <RegistryValue - Root='HKMU' Key='Software\Microsoft\Windows\CurrentVersion\Shell Extensions\Approved' + Root='HKLM' Key='Software\Microsoft\Windows\CurrentVersion\Shell Extensions\Approved'   Type='string' Name='$(var.CLSID_TortoiseHgCmenu)' Value='TortoiseHg'   />   <RegistryValue - Root='HKMU' Key='Software\Microsoft\Windows\CurrentVersion\Shell Extensions\Approved' + Root='HKLM' Key='Software\Microsoft\Windows\CurrentVersion\Shell Extensions\Approved'   Type='string' Name='$(var.CLSID_TortoiseHgNormal)' Value='TortoiseHg'   />   <RegistryValue - Root='HKMU' Key='Software\Microsoft\Windows\CurrentVersion\Shell Extensions\Approved' + Root='HKLM' Key='Software\Microsoft\Windows\CurrentVersion\Shell Extensions\Approved'   Type='string' Name='$(var.CLSID_TortoiseHgAdded)' Value='TortoiseHg'   />   <RegistryValue - Root='HKMU' Key='Software\Microsoft\Windows\CurrentVersion\Shell Extensions\Approved' + Root='HKLM' Key='Software\Microsoft\Windows\CurrentVersion\Shell Extensions\Approved'   Type='string' Name='$(var.CLSID_TortoiseHgModified)' Value='TortoiseHg'   />   <RegistryValue - Root='HKMU' Key='Software\Microsoft\Windows\CurrentVersion\Shell Extensions\Approved' + Root='HKLM' Key='Software\Microsoft\Windows\CurrentVersion\Shell Extensions\Approved'   Type='string' Name='$(var.CLSID_TortoiseHgUnversioned)' Value='TortoiseHg'   />  </Include>