Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 1.0, 1.0.1, and 1.0.2

gdialog: do not set $HGUSER in editor environment

This places an extra dependency on ui.username being configured before you can
edit any files. If ui.username was unconfigured, it threw a traceback. It's
not clear $HGUSER was ever necessary here, it was simply copy-pasted from hg's
editor code where you clearly do want $HGUSER for commits. We're not launching
an external editor for commits.

Changeset 9dbc9526bc1c…

Parent f605318a1ea2…

by Steve Borho

Changes to one file · Browse files at 9dbc9526bc1c Showing diff from parent f605318a1ea2 Diff from another changeset...

Change 1 of 1 Show Entire File tortoisehg/​hgtk/​gdialog.py Stacked
 
658
659
660
661
662
663
664
 
658
659
660
 
661
662
663
@@ -658,7 +658,6 @@
  paths = ['"%s"' % os.path.join(pathroot, f) for f in files]   command = '%s %s' % (editor, ' '.join(paths))   util.system(command, - environ={'HGUSER': self.ui.username()},   onerr=self.ui, errprefix=_('edit failed'))     editor = (self.ui.config('tortoisehg', 'editor') or