by
Changes to 3 files · Browse files at a2b311fa5405 Showing diff from parent 2a6db97a7aba 7c905f0daee9 Diff from another changeset...
@@ -36,30 +36,26 @@ msg = _("Invalid Settings - Please provide your ReviewBoard username")
else:
rb = extensions.find("reviewboard")
- plugin_msg = _("Invalid reviewboard plugin. Please download the "
+ try:
+ pwd = self.dialog.password
+ #if we don't have a password send something here to skip
+ #the cli getpass in the extension. We will set the password
+ #later
+ if not pwd:
+ pwd = "None"
+
+ self.reviewboard = rb.make_rbclient(self.dialog.server,
+ self.dialog.user,
+ pwd)
+ self.loadCombos()
+
+ except rb.ReviewBoardError, e:
+ msg = e.msg
+ except TypeError:
+ msg = _("Invalid reviewboard plugin. Please download the "
"mercurial reviewboard plugin version 3.5 or higher "
"from the website below.\n\n %s") % \
u'http://bitbucket.org/mdelagra/mercurial-reviewboard/'
- try:
- if float(rb.__version__[:3]) < 3.5:
- msg = plugin_msg
- else:
- pwd = self.dialog.password
- #if we don't have a password send something here to skip
- #the cli getpass in the extension. We will set the password
- #later
- if not pwd:
- pwd = "None"
-
- self.reviewboard = rb.make_rbclient(self.dialog.server,
- self.dialog.user,
- pwd)
- self.loadCombos()
-
- except rb.ReviewBoardError, e:
- msg = e.msg
- except AttributeError:
- msg = plugin_msg
self.dialog.error_message = msg
@@ -387,8 +383,11 @@ @pyqtSlot()
def onSettingsButtonClicked(self):
from tortoisehg.hgqt import settings
-
- settings.SettingsDialog(parent=self, focus='reviewboard.server').exec_()
+ if settings.SettingsDialog(parent=self, focus='reviewboard.server').exec_():
+ # not use repo.configChanged because it can clobber user input
+ # accidentally.
+ self.repo.invalidateui() # force reloading config immediately
+ self.readSettings()
def run(ui, *pats, **opts):
revs = opts.get('rev') or None
|
@@ -338,6 +338,22 @@ </hints>
</connection>
<connection>
+ <sender>settings_button</sender>
+ <signal>clicked()</signal>
+ <receiver>PostReviewDialog</receiver>
+ <slot>onSettingsButtonClicked()</slot>
+ <hints>
+ <hint type="sourcelabel">
+ <x>20</x>
+ <y>20</y>
+ </hint>
+ <hint type="destinationlabel">
+ <x>20</x>
+ <y>20</y>
+ </hint>
+ </hints>
+ </connection>
+ <connection>
<sender>close_button</sender>
<signal>clicked()</signal>
<receiver>PostReviewDialog</receiver>
|
@@ -54,11 +54,11 @@ vbox = QVBoxLayout()
vbox.setContentsMargins(*MARGINS)
hbox.addLayout(vbox)
- auto = QPushButton(_('Auto Resolve'))
- auto.setToolTip(_('Attempt automatic merge'))
+ auto = QPushButton(_('Mercurial Resolve'))
+ auto.setToolTip(_('Attempt automatic (trivial) merge'))
auto.clicked.connect(lambda: self.merge('internal:merge'))
- manual = QPushButton(_('Manual Resolve'))
- manual.setToolTip(_('Merge with selected merge tool'))
+ manual = QPushButton(_('Tool Resolve'))
+ manual.setToolTip(_('Merge using selected merge tool'))
manual.clicked.connect(self.merge)
local = QPushButton(_('Take Local'))
local.setToolTip(_('Accept the local file version (yours)'))
|
Loading...