Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in tip

fogcreek shellext: handle temporary file with CAtlTemporaryFile

Changeset d074300ef351…

Parent 41ab2d81c589…

by David Golub

Changes to 3 files · Browse files at d074300ef351 Showing diff from parent 41ab2d81c589 Diff from another changeset...

Change 1 of 2 Show Entire File win32/​shellext/​RunDialog.cpp Stacked
 
98
99
100
101
102
 
 
103
104
 
105
106
107
108
109
110
111
112
113
114
115
 
116
117
118
 
129
130
131
 
 
132
133
134
135
136
 
98
99
100
 
 
101
102
103
 
104
105
106
 
 
 
 
 
 
 
 
 
107
108
109
110
 
121
122
123
124
125
126
 
127
128
129
@@ -98,21 +98,13 @@
    if (!listFiles.IsEmpty())   { - CString strTempFile = GetTemporaryFile(); - if (strTempFile.IsEmpty()) + CAtlTemporaryFile file; + if (FAILED(file.Create()))   { - ATLTRACE("***** RunDialog: error: GetTemporaryFile returned empty string\n"); + ATLTRACE("***** RunDialog: error: failed to create temporary file\n");   return;   } - - ATLTRACE("RunDialog: temp file = %s\n", (LPCTSTR)strTempFile); - CAtlFile file; - if (FAILED(file.Create(strTempFile, GENERIC_WRITE, FILE_SHARE_READ, CREATE_ALWAYS))) - { - ATLTRACE("***** RunDialog: error: failed to create file '%s'\n", - (LPCTSTR)strTempFile); - return; - } + ATLTRACE("RunDialog: temp file = '%s'\n", file.TempFileName());     POSITION position = listFiles.GetHeadPosition();   while (position != NULL) @@ -129,8 +121,9 @@
  file.Write("\n", 1);   }   + strHgCmd += " --listfile "; + strHgCmd += file.TempFileName();   file.Close(); - strHgCmd += " --listfile " + Quote(strTempFile);   }     LaunchCommand(strHgCmd, strCwd);
Change 1 of 1 Show Changes Only win32/​shellext/​TortoiseUtils.cpp Stacked
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
 // Copyright (C) 2011 Fog Creek Software  //  // This program is free software: you can redistribute it and/or modify  // it under the terms of the GNU General Public License as published by  // the Free Software Foundation, either version 2 of the License, or  // (at your option) any later version.  //  // This program is distributed in the hope that it will be useful,  // but WITHOUT ANY WARRANTY; without even the implied warranty of  // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the  // GNU General Public License for more details.  //  // You should have received a copy of the GNU General Public License  // along with this program. If not, see <http://www.gnu.org/licenses/>.    #include "stdafx.h"    #include "TortoiseUtils.h"    #include <io.h>  #include <fcntl.h>    CString GetTHgProgRoot()  {   LPCTSTR lpszKeyName = "Software\\TortoiseHg";   HKEY hKey = HKEY_LOCAL_MACHINE;   TCHAR lpszValue[MAX_PATH] = "";   LONG lpcbLonger = MAX_PATH * sizeof(TCHAR);     if (::RegQueryValue(hKey, lpszKeyName, lpszValue, &lpcbLonger) != ERROR_SUCCESS)   {   return "";   }     return lpszValue;  }    // Start an external command  // Note: if the command is a batch file and the [full] path to the  // batch contains spaces, the path must be double-quoted.  // (see http://www.encocoservices.com/createprocess.html)  bool LaunchCommand(const CString& strCommand, const CString& strCwd)  {   ATLTRACE("LaunchCommand: %s\n", (LPCTSTR)strCommand);   ATLTRACE("LaunchCommand: in '%s'\n", (LPCTSTR)strCwd);   PROCESS_INFORMATION pi;   memset(&pi, 0, sizeof(PROCESS_INFORMATION));     STARTUPINFOA si;   memset(&si, 0, sizeof(STARTUPINFO));     BOOL bRes = ::CreateProcess(   NULL, // No module name, use command line   (LPTSTR)(LPCTSTR)strCommand,   NULL, // Process handle not inherited   NULL, // Thread handle not inherited   FALSE,   CREATE_NO_WINDOW,   NULL, // use parent's environment   strCwd,   &si,   &pi);     if (bRes == 0)   {   ATLTRACE("LaunchCommand: failed to launch\n");   return false;   }     ::CloseHandle(pi.hProcess);   ::CloseHandle(pi.hThread);   return true;  }   -CString GetTemporaryFile(LPCTSTR strPrefix) -{ - char szTempDir[MAX_PATH + 1]; - char szTempFile[MAX_PATH + 1]; - - if (::GetTempPath(MAX_PATH, szTempDir) == 0) - { - ATLTRACE("GetTemporaryFile: Failed to find temporary path\n"); - } - else if (::GetTempFileName(szTempDir, strPrefix, 0, szTempFile) != 0) - { - return szTempFile; - } - else - { - ATLTRACE("GetTemporaryFile: Failed to get temporary file\n"); - } - - return ""; -} -  CString DirName(const CString& strFileName)  {   if (strFileName.IsEmpty()) return strFileName;   int nPos = strFileName.ReverseFind('\\');   if (nPos == -1) return "";   CString strDirName = strFileName.Left(nPos);   if (!strDirName.IsEmpty() && strDirName[strDirName.GetLength()-1] == ':')   {   strDirName.AppendChar('\\');   }   return strDirName;  }    CString BaseName(const CString& strFileName)  {   if (strFileName.IsEmpty()) return strFileName;   int nPos = strFileName.ReverseFind('\\');   if (nPos == -1) return strFileName;   return strFileName.Mid(nPos+1);  }    // not reentrant  HICON GetTortoiseIcon(const CString& strIconName)  {   typedef CAtlMap<CString, HICON> CIconCache;   static CIconCache iconcache;     CString thgdir = GetTHgProgRoot();   if (thgdir.IsEmpty())   {   ATLTRACE("GetTortoiseIcon: THG root is empty\n");   return 0;   }     CString strIconPath = thgdir + "\\icons\\" + strIconName;     const CIconCache::CPair* p = iconcache.Lookup(strIconName);   if (p != NULL) return p->m_value;     if (iconcache.GetCount() > 200)   {   ATLTRACE("**** GetTortoiseIcon: error: too many icons in cache\n");   return 0;   }     HICON hIcon = (HICON)::LoadImage(0, strIconPath, IMAGE_ICON,   16, 16, LR_LOADFROMFILE);   if (!hIcon)   {   ATLTRACE("GetTortoiseIcon: can't find '%s'\n", (LPCTSTR)strIconPath);   return 0;   }     iconcache[strIconPath] = hIcon;     ATLTRACE("GetTortoiseIcon: added '%s' to iconcache_ (%d icons in cache)\n",   (LPCTSTR)strIconPath, iconcache.GetCount());     return hIcon;  }    CString GetHgRepoRoot(LPCTSTR lpszPath)  {   ATLTRACE("GetHgRepoRoot('%s')\n", lpszPath);     CString strPath = (::PathIsUNCServerShare(lpszPath) || ::PathIsDirectory(lpszPath)) ?   lpszPath : DirName(lpszPath);   for (;;)   {   CString strHgDir = strPath + "\\.hg";   if (::PathIsUNCServerShare(strHgDir))   {   ATLTRACE("GetHgRepoRoot: tdir is UNC share '%s'\n", (LPCTSTR)strHgDir);   strPath.Empty();   break;   }   else if (::PathIsDirectory(strHgDir))   {   break;   }   CString strOldPath = strPath;   strPath = DirName(strPath);   if (strPath == strOldPath)   {   strPath.Empty();   break;   }   }     ATLTRACE("GetHgRepoRoot: returning '%s'\n", (LPCTSTR)strPath);   return strPath;  }    bool IsHgRepo(LPCTSTR lpszPath)  {   return !GetHgRepoRoot(lpszPath).IsEmpty();  }    // read string value from registry, wide version  bool GetRegSZValueW(HKEY hKey, LPCWSTR lpszName, CStringW& strRes)  {   strRes = L"";   if (!hKey) return 0;     DWORD cbData = 600;   LPWSTR lpszData = strRes.GetBuffer(cbData);   LONG lRes = ::RegQueryValueExW(hKey, lpszName, 0, 0, (LPBYTE)lpszData, &cbData);   strRes.ReleaseBuffer(cbData);     if (lRes == ERROR_SUCCESS) return true;   ATLTRACE(L"GetRegSZValueW('%s') failed\n", lpszName);   return false;  }    // true if a starts with b  bool StartsWith(const CString& strWhole, const CString& strPrefix)  {   if (strWhole.IsEmpty() || strPrefix.IsEmpty()) return false;   if (strPrefix.GetLength() > strWhole.GetLength()) return false;     for (int i = 0; i < strPrefix.GetLength(); ++i)   {   if (strWhole[i] != strPrefix[i]) return false;   }     return true;  }    void Tokenize(CString str, CAtlList<CString>& rTokens, LPCTSTR lpszDelimiters)  {   int nPos = 0;   CString strToken = str.Tokenize(lpszDelimiters, nPos);   while (!strToken.IsEmpty())   {   rTokens.AddTail(strToken);   strToken = str.Tokenize(lpszDelimiters, nPos);   }  }
Change 1 of 1 Show Entire File win32/​shellext/​TortoiseUtils.h Stacked
 
16
17
18
19
20
21
22
 
16
17
18
 
19
20
21
@@ -16,7 +16,6 @@
 #pragma once    CString GetTHgProgRoot(); -CString GetTemporaryFile(LPCSTR strPrefix = "THG");  CString DirName(const CString& strFileName);  CString BaseName(const CString& strFileName);  bool LaunchCommand(const CString& strCommand, const CString& strCwd);