Kiln » TortoiseHg » TortoiseHg
Clone URL:  
Pushed to one repository · View In Graph Contained in 1.9, 1.9.1, and 1.9.2

workbench: don't endlessly pile 'filled' signal connections

The previous code pointlessly caused a new 'filled' signal connection to be added
to self.textview_status on *every call* of file_displayed().

Moving this to createActions(), so we get only a single 'filled' signal connection per
workbench object for this.

Changeset e3eccbb85523…

Parent 9c51560cca6c…

by Adrian Buehlmann

Changes to one file · Browse files at e3eccbb85523 Showing diff from parent 9c51560cca6c Diff from another changeset...

Change 1 of 2 Show Entire File tortoisehg/​hgqt/​workbench.py Stacked
 
230
231
232
 
 
 
 
233
234
235
 
447
448
449
450
451
452
453
454
455
456
 
230
231
232
233
234
235
236
237
238
239
 
451
452
453
 
 
 
 
454
455
456
@@ -230,6 +230,10 @@
  # Next/Prev diff (in full file mode)   self.actionNextDiff = QtGui.QAction(geticon('down'), 'Next diff', self)   self.actionNextDiff.setShortcut('Alt+Down') + def filled(): + self.actionNextDiff.setEnabled( + self.textview_status.fileMode() and self.textview_status.nDiffs()) + connect(self.textview_status, SIGNAL('filled'), filled)   self.actionPrevDiff = QtGui.QAction(geticon('up'), 'Previous diff', self)   self.actionPrevDiff.setShortcut('Alt+Up')   connect(self.actionNextDiff, SIGNAL('triggered()'), @@ -447,10 +451,6 @@
    def file_displayed(self, filename):   self.actionPrevDiff.setEnabled(False) - def filled(): - self.actionNextDiff.setEnabled( - self.textview_status.fileMode() and self.textview_status.nDiffs()) - connect(self.textview_status, SIGNAL('filled'), filled)     def revision_selected(self, rev):   """